[#358] Remove Rising and Completed sort options from home page#364
Merged
realproject7 merged 1 commit intomainfrom Mar 19, 2026
Merged
[#358] Remove Rising and Completed sort options from home page#364realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Remove "Rising" and "Completed" from sort options, case branches, and the getRisingStorylines function from ranking.ts. Both were redundant/unused with the current storyline count. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches issue #358 and removes the redundant Rising and Completed sort paths cleanly from the filter UI, page query logic, and ranking helpers. The change is focused and leaves Recent/Trending as the only supported tabs, which matches the requested cleanup.
Findings
- No correctness or design issues found in the submitted diff.
Decision
Approved on code review. lint-and-typecheck was still pending at the time of review, so merge should still wait for required GitHub checks.
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Clean removal of Rising/Completed — sort options, case branches, and ~120 lines of getRisingStorylines all gone. TABS type narrows correctly. Old URLs fall back to Recent. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterBar.tsxpage.tsx(completed query + rising call)getRisingStorylinesfromlib/ranking.ts(no longer used)Fixes #358
Files changed
src/components/FilterBar.tsx— removed 2 sort optionssrc/app/page.tsx— removed import, TABS entries, and case brancheslib/ranking.ts— removedgetRisingStorylines(120 lines)Test plan
next buildpasses?tab=risingor?tab=completedgracefully fall back to "Recent"🤖 Generated with Claude Code